Skip to content

UIPG, UIST: Add support for Launchpad Page and Space Templates #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 21, 2024
Merged

UIPG, UIST: Add support for Launchpad Page and Space Templates #6873

merged 11 commits into from
Mar 21, 2024

Conversation

ViktoriaFreidel
Copy link
Contributor

Register new SAP Object in abapGit

@larshp
Copy link
Member

larshp commented Mar 20, 2024 •
edited
Loading

make sure to downport to 702 syntax, and if objects doesnt exist on 702 change it to dynamic calls

#6850

mbtools
mbtools requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We know it's a pain but abapGit supports 702 and higher so you can't use 740 language features. Objects that don't exist must be coded dynamically. Best to look at some other classes on how it's done there.

src/objects/aff/zcl_abapgit_object_uipg.clas.abap Outdated
iv_language = sy-langu ).
rv_user = ls_metadata-changed_by.

CATCH /ui2/cx_uipg INTO DATA(lx_error).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with cx_root

mbtools
mbtools reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two shortcuts but looks good otherwise

@mbtools
Copy link
Member

mbtools commented Mar 20, 2024

something went wrong. there's duplicate code in the change-by methods.

@ViktoriaFreidel
Copy link
Contributor Author

Sorry, I damage the code. :-( . The merge of conflicts did what I don't wanted. I will send a fix.

@mbtools
Copy link
Member

mbtools commented Mar 20, 2024

The language is set in the constructor. I replaced sy-langu accordingly.

mbtools
mbtools approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbtools
Copy link
Member

mbtools commented Mar 20, 2024

Please create minimal test cases in https://github.com/abapGit-tests/UIPG and https://github.com/abapGit-tests/UIST. Thanks!

@mbtools mbtools changed the title Add abapGit Handlers for Object Typs UIST, UIPG UIPG, UIST: Add support for Launchpad Page and Space Templates Mar 20, 2024
@mbtools mbtools added serialization Translate between object types and files new feature New feature or request labels Mar 20, 2024
@ViktoriaFreidel
Copy link
Contributor Author

Hi, I try to add a simple test in https://github.com/abapGit-tests/UIST. How can I merge pull request abapGit-tests/UIST#1. It is about missing write access.
Could you help to set a correct rights to be able add a test in those repositories?
BR, Viktoria

@ViktoriaFreidel ViktoriaFreidel requested a review from mbtools March 21, 2024 08:59
@larshp
Copy link
Member

larshp commented Mar 21, 2024

does these object types have entries in TADIR?

@ViktoriaFreidel
Copy link
Contributor Author

ViktoriaFreidel commented Mar 21, 2024 •
edited
Loading

Yes, both object types have entries in TADIR
PGMID R3TR
OBJECT UIST or UIPG
OBJ NAME =Space or Page Id

mbtools
mbtools approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@larshp
Copy link
Member

larshp commented Mar 21, 2024

welcome to abapGit as a contributor 🎉

@larshp larshp merged commit 17a59c4 into abapGit:main Mar 21, 2024
@ViktoriaFreidel ViktoriaFreidel mentioned this pull request Mar 21, 2024
Open
37 tasks
@larshp larshp mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbtools mbtools mbtools approved these changes

Assignees
No one assigned
Labels
new feature New feature or request serialization Translate between object types and files
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktoriaFreidel @larshp @mbtools