Skip to content

Commit 1af0428

Browse files
committed
fix lag for Alert Dialog
1 parent bad6bec commit 1af0428

File tree

3 files changed

+18
-15
lines changed

3 files changed

+18
-15
lines changed

lib/Screens/Extensions/ExtensionScreen.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,18 @@ class _BrowseScreenState extends ExtensionManagerScreen<ExtensionScreen> {
6767
IconButton(
6868
icon: Icon(Icons.language_rounded, color: theme.primary),
6969
onPressed: () {
70+
var language = completeLanguageName(currentLanguage);
71+
7072
AlertDialogBuilder(context)
7173
..setTitle(getString.language)
7274
..singleChoiceItems(
7375
sortedLanguagesMap.keys.toList(),
74-
sortedLanguagesMap.keys.toList().indexOf(currentLanguage),
76+
sortedLanguagesMap.keys.toList().indexOf(language),
7577
(index) {
7678
onLanguageChanged(
77-
sortedLanguagesMap.keys.elementAt(index),
79+
completeLanguageCode(
80+
sortedLanguagesMap.keys.elementAt(index),
81+
),
7882
);
7983
},
8084
)

lib/Screens/Settings/language.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ String completeLanguageCode(String lang) {
1919
}
2020

2121
final sortedLanguagesMap = {
22-
"all": "All",
22+
"All": "all",
2323
"Afrikaans": "af",
2424
"አማርኛ": "am",
2525
"العربية": "ar",

lib/Widgets/AlertDialogBuilder.dart

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -278,18 +278,17 @@ class AlertDialogBuilder {
278278
},
279279
);
280280

281-
Widget _buildListContent(Widget Function(String) itemBuilder) =>
282-
ConstrainedBox(
283-
constraints: BoxConstraints(
284-
minWidth: MediaQuery.of(context).size.width * 0.7,
285-
),
286-
child: SingleChildScrollView(
287-
child: Column(
288-
mainAxisSize: MainAxisSize.min,
289-
children: _items!.map(itemBuilder).toList(),
290-
),
291-
),
292-
);
281+
Widget _buildListContent(Widget Function(String) itemBuilder) {
282+
final media = MediaQuery.of(context).size;
283+
return SizedBox(
284+
width: media.width * 0.7,
285+
height: media.height * 0.8,
286+
child: ListView.builder(
287+
itemCount: _items!.length,
288+
itemBuilder: (_, index) => itemBuilder(_items![index]),
289+
),
290+
);
291+
}
293292

294293
Widget _buildDefaultContent() => ConstrainedBox(
295294
constraints: BoxConstraints(

0 commit comments

Comments
 (0)