Skip to content

Fix locale fallback for substitute holiday #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2019
Merged

Fix locale fallback for substitute holiday #180

merged 2 commits into from
Oct 8, 2019

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Oct 7, 2019

Locale fallback for the substituteHoliday pattern does not work (my bad).

E.g. for en_GB, the name is currently “Foo Day observed”. The expected name is “Foo Day (substitute day)”.

@stelgenhof stelgenhof merged commit 1f8b029 into azuyalabs:develop Oct 8, 2019
@c960657 c960657 deleted the substitute-holiday-fallback branch March 17, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stelgenhof stelgenhof stelgenhof approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c960657 @stelgenhof