Get summer/winter time from PHP timezone library #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I think it is a good one, since it can now be used by other Holiday Providers as well. Always love a good refactor :) |
stelgenhof
reviewed
Mar 17, 2018
| $transition = array_shift($transitions); | ||
| $dst = $transition['isdst']; | ||
|
|
||
| foreach ($transitions as $transition) { |
There was a problem hiding this comment.
It seems you rely on the fact that the getTransitions function returns the transitions sorted by time, correct? If returned randomly, I think getting the transitions for summer and wintertime then might not work this way.
There was a problem hiding this comment.
AFAICT from the PHP source code, we can rely on the dates being returned in chronological order. It seems the underlying data structure is also sorted by date.
|
Travis is happy now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date of transition to/from daylight saving time, and whether daylight saving time has been used at all, has changed over the years. This information is available in the tz (Olson) database that is included in PHP.
This PR makes Yasumi use the tz database for calculating the transitions. This works for any timezone that observes daylight saving time.
It seems that PHP currently only supports years until 2037 (when Unix timestamps exceed 31 bits), but this will likely be fixed in due time, if daylight saving time exists at all at that time.