Implement column number parsing #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously tag would only take you to the line of the given match. Now it also takes you directly to the column that was matched.
|
This is great, thanks for writing it! One quick question - do you know why linenum (and now colnum in your PR) are written as string rather than int? I'm not a Go expert - the code seems to work fine like this just curious if there's a reason for that. |
|
Well in this case we don't have any reason to cast it to an int, since we're parsing it and writing it as a string. So I guess there's just no need for that extra step. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tag would only take you to the line of the given match. Now
it also takes you directly to the column that was matched.