migrate: install rustfmt from rustup (#842)
#845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure! But how can we ensure proper installation (of |
IMO the most direct way is adding EDIT: for rust users |
I think we can just check if |
OK, I had added it in the prerequisites. |
rustfmt from rustup (#815)rustfmt from rustup (#842)
|
|
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we include
rustupinstallation in our installation scripts?Besides
rustfmt,sniprunalso needscargoto compile, so I think it might be acceptable to add it.cc @Jint-lzxy @ClSlaid @volpan