Skip to content

Conversation

Jint-lzxy
Copy link
Collaborator

This commit should fix a weird bug where nvim_get_hl would return an empty dict when trying to get hl-Statusline inside toggleterm. Not 100% sure why this was happening or what exact conditions caused it, but with this fix lualine now shows the right backgrounds in terminal mode!

  • Before (notice that eg the git section doesn't have proper guibg):
    before
  • After:
    after

This commit should fix a weird bug where `nvim_get_hl` would return an empty
dict when trying to get `hl-Statusline` inside `toggleterm`. Not 100% sure why
this was happening or what exact conditions caused it, but with this fix lualine
now shows the right backgrounds in terminal mode!

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure its influence but LGTM.

@ayamir ayamir merged commit 7acd22d into ayamir:main Dec 12, 2024
2 checks passed
Deg2v pushed a commit to Deg2v/nvimdots that referenced this pull request Jan 16, 2025
This commit should fix a weird bug where `nvim_get_hl` would return an empty
dict when trying to get `hl-Statusline` inside `toggleterm`. Not 100% sure why
this was happening or what exact conditions caused it, but with this fix lualine
now shows the right backgrounds in terminal mode!

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
@Jint-lzxy Jint-lzxy mentioned this pull request Mar 28, 2025
9 tasks
Jint-lzxy added a commit that referenced this pull request Mar 28, 2025
This commit addresses the root cause of #1381 by allowing lualine to
automatically select the default background color. Previously, lualine attempted
to retrieve the background manually, which could lead to issues when querying in
a different namespace (and resulting in an empty dictionary).

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Jint-lzxy added a commit that referenced this pull request Mar 28, 2025
This commit addresses the root cause of #1381 by allowing lualine to
automatically select the default background color. Previously, lualine attempted
to retrieve the background manually, which could lead to issues when querying in
a different namespace (and resulting in an empty dictionary).

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
@Jint-lzxy Jint-lzxy deleted the fix/bufferline-statline-hl branch March 28, 2025 07:11
ayamir pushed a commit that referenced this pull request Apr 5, 2025
This commit addresses the root cause of #1381 by allowing lualine to
automatically select the default background color. Previously, lualine attempted
to retrieve the background manually, which could lead to issues when querying in
a different namespace (and resulting in an empty dictionary).

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
ayamir added a commit that referenced this pull request Apr 20, 2025
* feat(options): make omnifunc support fuzzy matching (#1441)

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat(treesitter): remove performance limitations (#1442)

This commit removes all previous performance restrictions as treesitter now
supports full asynchronous parsing.

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(lualine): resolve background color defaulting issue (#1443)

This commit addresses the root cause of #1381 by allowing lualine to
automatically select the default background color. Previously, lualine attempted
to retrieve the background manually, which could lead to issues when querying in
a different namespace (and resulting in an empty dictionary).

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* fix(keymap): prevent new builtins from interfering with our keymap (#1444)

This commit prevents lag when using `gr` by avoiding conflicts with new keymaps
Neovim defines with this prefix.

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>

* feat: support virtual_line and adapt to the latest diagnostics interface. (#1447)

* feat: add setting entry for virtual lines.

* fix: hide or show virtual text and lines instead of diagnostics itself.

* fix: correct comment.

* fix: restore comment note.

* fix: toggle inlay hints correctly. (#1449)

* fix: toggle inlay hints correctly.

Previous impl won't work when toggle for the first time.

* fix: toggle for all buffers.

* fix: replace project.nvim with newest apis. (#1450)

* feat: add garbage-dev to save memory for inactive lsp.

* fix: remove underline for diagnostics.

* Revert "feat: add garbage-dev to save memory for inactive lsp."

This reverts commit 0ccac94.

* Revert "fix: remove underline for diagnostics."

This reverts commit bb1d274.

* feat: use tiny inline diagnostics to manage virtual text. (#1452)

* feat: add tiny inline diagnostic.

* refactor: disable virtual text by default.

---------

Signed-off-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: Charles Chiu <charleschiu@hey.com>

---------

Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
Signed-off-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com>
Co-authored-by: Charles Chiu <charleschiu@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants