Skip to content

New metrics functionality spamming api.github.com #522

@avesst

Description

@avesst

Hi,

The new Prometheus metrics endpoint introduced in #505 causes Mailpit to poll api.github.com to check for new versions of Mailpit two times every second minute making our organisation hit the Github rate limit for unauthenticated users.

This causes issues for other parts in our organisation using Githubs API (for instance, Packer and Terraform plugins are fetched from Github).

From what I've gathered, this is caused by prometheus.UpdateMetrics() calling stats.Load() which in turn calls updater.GithubLatest(), though I haven't been able to figure out why it's causing two requests each iteration as seen in our firewall logs.

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions