Skip to content

Conversation

CeRiAl
Copy link
Member

@CeRiAl CeRiAl commented Jun 3, 2025

No description provided.

@CeRiAl CeRiAl self-assigned this Jun 3, 2025
@CeRiAl CeRiAl added this to the v0.23.4 milestone Jun 3, 2025
@CeRiAl CeRiAl modified the milestones: v0.23.4, v0.24 Jun 4, 2025
@CeRiAl CeRiAl changed the title Add MapFields to Dataset struct Add MapFields to Dataset struct, add support for listing, creation, updating & deletion of MapFields Jun 4, 2025
ronoc
ronoc previously approved these changes Jun 4, 2025
@CeRiAl CeRiAl marked this pull request as ready for review June 5, 2025 14:17
@CeRiAl CeRiAl requested a review from lukasmalkmus as a code owner June 5, 2025 14:17
Copy link
Collaborator

@lukasmalkmus lukasmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but please add integration tests before we merge this.

@CeRiAl CeRiAl requested a review from lukasmalkmus June 11, 2025 09:59
Copy link
Collaborator

@lukasmalkmus lukasmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmalkmus lukasmalkmus merged commit 21cd122 into main Jun 11, 2025
24 checks passed
@lukasmalkmus lukasmalkmus deleted the add-mapfields-to-dataset-struct branch June 11, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants