Skip to content

Conversation

CeRiAl
Copy link
Member

@CeRiAl CeRiAl commented May 19, 2025

This PR/branch is a dependency of axiomhq/terraform-provider-axiom#64

@CeRiAl CeRiAl self-assigned this May 19, 2025
@CeRiAl CeRiAl added the enhancement New feature or request label May 19, 2025
CeRiAl added 2 commits May 20, 2025 01:46
…tasetCreateRequest` & `DatasetUpdateRequest` types
…tsService_Update` to ensure proper state of dataset retention settings
@CeRiAl CeRiAl force-pushed the add-retention-parameters-to-create-and-update-dataset-structs branch from dc7195b to 04a45ae Compare May 19, 2025 23:49
@CeRiAl CeRiAl changed the title Axiom/Datasets: Add UseRetentionPeriod & RetentionDays to the DatasetCreateRequest & DatasetUpdateRequest Axiom/Datasets: Add UseRetentionPeriod & RetentionDays to the DatasetCreateRequest & DatasetUpdateRequest structs May 20, 2025
@CeRiAl CeRiAl added this to the v0.23.3 milestone May 20, 2025
@CeRiAl CeRiAl marked this pull request as ready for review May 20, 2025 01:09
@CeRiAl CeRiAl requested a review from lukasmalkmus as a code owner May 20, 2025 01:09
Copy link
Collaborator

@lukasmalkmus lukasmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmalkmus lukasmalkmus merged commit dab7180 into main May 20, 2025
26 checks passed
@lukasmalkmus lukasmalkmus deleted the add-retention-parameters-to-create-and-update-dataset-structs branch May 20, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants