feat(s2n-quic-core) TLS offloading #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Jul 22, 2025
Comment on lines
+152
to
+207
| let cloned_waker = &context.waker().clone(); | ||
| let mut ctx = core::task::Context::from_waker(cloned_waker); |
There was a problem hiding this comment.
why do you need to clone this?
There was a problem hiding this comment.
I am using context to both call the Context trait methods(e.g. context.on_handshake_keys()) and in the poll_slice function in line 155. Essentially, I can't borrow the context twice if one of the borrows in mutable(which it is.) So I'm cloning this to get around it.
Comment on lines
113
to
147
| if let Poll::Ready(Ok(mut slice)) = send_to_quic.poll_slice(ctx) { | ||
| match res { | ||
| Ok(()) => { | ||
| let _ = slice.push(Msg::TlsDone); | ||
| } | ||
|
|
||
| Err(e) => { | ||
| let _ = slice.push(Msg::TlsError(e)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm a little worried about messages getting dropped... But I guess it would only happen if the TLS implementation sends a lot of messages at once.
camshaft
reviewed
Jul 30, 2025
camshaft
reviewed
Jul 31, 2025
camshaft
previously approved these changes
Jul 31, 2025
camshaft
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Adds unstable feature to move s2n-tls operations out of the main event loop.
Resolved issues:
resolves #2598
Description of changes:
Adds a new TLS provider that spawns an asynchronous task which will complete the TLS handshake.
I am closing #2688 in favor of this PR.
Call-outs:
Testing:
New integ tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.