ci(fix): resolve flakiness in upd::fuzz_test #2689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
The daily scheduled CI run detected flakiness in
udp::fuzz_test
. I changed the test in my forked repo with the failed input. The test would run successfully locally in my EC2 instance, but failed in GithubAction. The changed code can be found in this snippet. I believe that the reason for such failure in GithubAction is because the EC2 instance runs faster than the one that GithubAction is ran on. I then increase the test duration from 120 seconds to 300 seconds, and the test succeeded:I then run the same test but update the test duration to 180 seconds, and the test succeeded as well. Hence, I conclude that the
udp::fuzz_test
flakiness is due to the test duration.Bolero
sometimes generate a client and server that needs a long time to run the test, which is causing the flakiness. Hence, increase the test duration will mitigate that.Call-outs:
Testing:
Already mentioned the test method in the section of
Description of changes
.Analysis:
The failed input looks like:
The server's
max_read_len
is set to 1 due to fuzz test randomness, which makes the server to read extremely slow. I believe that's why this test is taking a long time.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.