fix(s2n-quic-dc): detect truncated streams #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we ignored the return from poll_read on the underlying TcpStream (poll_fill_once calls into that), which meant that a truncated stream caused effectively a busy loop trying to parse the last packet to be sent on the stream.
0c5809e to
3e6a586
Compare
camshaft
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
Previously we ignored the return from poll_read on the underlying TcpStream (poll_fill_once calls into that), which meant that a truncated stream caused effectively a busy loop trying to parse the last packet to be sent on the stream.
Call-outs:
This fixes a known case but doesn't fix the class of bug definitively -- there may be other poll_read's hiding whose output is ignored. Unfortunately I'm not sure we have any good tooling for catching that, but I'll attempt to manually audit soon.
Testing:
See added unit test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.