feat(s2n-quic-dc): Expose dc::HandshakingPath publicly #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the HandshakingPath to allow consumers of the DcPathCreated event to store a copy of the path locally, allowing subsequent access after various events are handled (e.g., to pull out the path secret ID for logging). This also adjusts error propagation out of the HandshakingPath to preserve more detail about errors, again propagating that into the HandshakingPath for consumers to access if desired. This also avoids panics in a few cases in favor of failing just the one handshake.
maddeleine
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
This refactors the HandshakingPath to allow consumers of the DcPathCreated event to store a copy of the path locally, allowing subsequent access after various events are handled (e.g., to pull out the path secret ID for logging).
This also adjusts error propagation out of the HandshakingPath to preserve more detail about errors, again propagating that into the HandshakingPath for consumers to access if desired. This also avoids panics in a few cases in favor of failing just the one handshake.
Call-outs:
n/a
Testing:
Just refactoring (mostly exposing more types), no particular tests added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.