feat(s2n-quic-dc): Define dcQUIC stream connect events #2675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
reviewed
Jun 18, 2025
maddeleine
reviewed
Jun 18, 2025
maddeleine
reviewed
Jun 18, 2025
3d429d0 to
2e9c33a
Compare
maddeleine
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
This adds a set of events for stream opening, when dcQUIC owns the TCP connect() call. UDP streams likely want something similarly shaped but likely at least subtly different -- UDP connect() I think is either infallible or at least differently-fallible (e.g., exhausting our pool is perhaps a failure mode worth tracking there).
Call-outs:
The new events are attached to the endpoint rather than moving the ConnectionContext earlier -- that's not perfect, but it seems reasonable enough. I'm not super happy with not tracking some of the later failures (e.g., for sending the prelude) but that can come later and this is already a useful step.
Testing:
No tests added, but the modified code is run as part of our existing testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.