fix(dc/wireshark): Provide Rust edition to bindgen #2663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A new version of bindgen was released, which adds an
--editionargument to the rustfmt command that runs on the generated code.s2n-quic runs rustfmt with the 2018 edition. By default, bindgen uses the latest edition.
This caused our rustfmt to fail when checking the code generated by bindgen:
https://github.com/aws/s2n-quic/actions/runs/15526083389/job/43752623889#step:7:29
This PR runs bindgen with the Rust edition specified in our rustfmt config, ensuring bindgen's rustfmt and our rustfmt agree.
Testing:
The dc-wireshark CI jobs should succeed on this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.