ci(GithubAction): only run aws credential on upstream s2n-quic #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
reviewed
Jun 2, 2025
maddeleine
approved these changes
Jun 9, 2025
|
I will merge this in and monitor the result closely after this is merged in. |
boquan-fang
added a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #2651.
Description of changes:
We want to add logic to ensure that only
pushorscheduleevent to mainline s2n-quic will trigger AWS action to run. I believe that we only need to check if thegithub.repositoryisaws/s2n-quic.The following conversation has more details: https://github.com/boquan-fang/s2n-quic/actions/runs/15501459732, https://github.com/boquan-fang/s2n-quic/actions/runs/15501459733.
Call-outs:
We need to merge this PR into upstream. Pull down the code to local repo and then sync up with a forked s2n-quic repo to see if those jobs are not ran.
Testing:
We need two parts of testing:
Call-outssection, we should verify that a forked s2n-quic repo doesn't run those aws actions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.