ci: Pin to older docker version #2639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
commented
May 15, 2025
| @@ -8,7 +8,6 @@ negotiated_crypto!(OneRttKey, OneRttHeaderKey); | |||
|
|
|||
| impl crypto::OneRttKey for OneRttKey { | |||
| #[inline] | |||
| #[must_use] | |||
There was a problem hiding this comment.
Explanation: this attribute has no effect on trait implementations. It's the trait function itself that should use this attribute, and in this case, derive_next_key() does.
WesleyRosenblum
approved these changes
May 15, 2025
dougch
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
The newest ubuntu22/20250514 image is causing our interop tests to fail. I suspect it has to do with the docker version bump, which went from v26 to v28. Here I am pinning our docker version to one that we know works.
I don't think this is a great long-term solution, but I would like to get our CI working again. Opened a new issue for this: #2640
Call-outs:
Also fixing a new clippy lint.
Testing:
Ci should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.