events: Adds event for missing packet space when processing a packet #2615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this test, the client is sending |
WesleyRosenblum
approved these changes
Apr 22, 2025
dougch
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #2600
Description of changes:
Added event to trigger when a packet is dropped because the packet space hasn't been created yet. I added this into handle_initial, handle_cleartext_initial, handle_handshake, and handle_application.
Call-outs:
Testing:
It appears this event actually occurs in a dc quic handshake test. Evidently the server receives a handshake packet but doesn't have the handshake packet space at this point. Maybe this is expected? Seems like this test is meant to fail the handshake anyways. Any insights on this would be helpful.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.