fix(s2n-quic-dc): arm recv idle timer on init #2613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where the client hangs indefinitely due to the failure to arm the receive idle timer on initialization. The key changes include:
- Updated the idle timer initialization in the stream receive state to use a provided clock.
- Propagated the clock dependency through shared receiver state and the endpoint creation.
- Added a test to validate the fix for the idle timeout behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dc/s2n-quic-dc/src/stream/tests/idle_timeout.rs | Introduces a test for server inactivity that triggers the idle timer. |
| dc/s2n-quic-dc/src/stream/tests.rs | Registers the new idle_timeout test module. |
| dc/s2n-quic-dc/src/stream/recv/state.rs | Modifies the stream receive state constructor to set the idle timer using a clock. |
| dc/s2n-quic-dc/src/stream/recv/shared.rs | Updates the shared receive state constructor to incorporate the clock. |
| dc/s2n-quic-dc/src/stream/endpoint.rs | Passes the current time (clock value) to the shared receive state creation. |
d58e771 to
1e4c8dd
Compare
WesleyRosenblum
approved these changes
Apr 18, 2025
dougch
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change includes a fix to arm the recv idle timer on initialization. This avoids a hang where the server never sends a single packet (or the client never receives any), which means there is no timer armed and then the client hangs indefinitely.
Testing:
I added a test to show the fix working.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.