fix(s2n-quic-dc): only actively poll RPC response #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Poll the `writer` as long as it hasn't completed or the `reader` is still being polled | ||
| if !writer_finished { | ||
| writer_finished = writer.as_mut().poll(cx)?.is_ready(); | ||
| } |
There was a problem hiding this comment.
Are we worried about not clearing a socket readiness state that causes e.g. level-triggered notifications to keep firing? I think that's not an issue with mio on Linux, but not sure if we'd run into trouble on (say) Windows.
There was a problem hiding this comment.
Not sure I follow the question. If the reader finishes before the writer does, then it'll trigger the reader's drop implementation, which should notify the background task that the application has detached and it will drive it to completion.
Mark-Simulacrum
previously approved these changes
Apr 15, 2025
Co-authored-by: Mark Rousskov <thismark@amazon.com>
dougch
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change optimizes the stream RPC implementation where the client only "actively" polls the response to decide when to return. This is based on the assumption that if the server is able to send the entire response then it received the request, even if the local request state hasn't completely finished for whatever reason.
Testing:
The existing RPC tests show that this maintains all of the expected behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.