Avoid copy for unique Bytes in put_bytes #2589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Apr 4, 2025
dougch
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
This change optimizes a read to a BytesMut queue when the Bytes we're pushing is uniquely owned, and so we can zero-copy convert to a BytesMut.
Resolved issues:
n/a
Description of changes:
n/a
Call-outs:
This upgrades to bytes 1.7.2 as the minimum, I don't see anything concerning in the changelog or any explicit pinning (not sure why I had 1.6 in my local lockfile).
Testing:
Existing tests should cover this, no change in behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.