feat(s2n-quic-dc): support key association in dispatch queue allocator #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63e8a43 to
f06b730
Compare
Mark-Simulacrum
approved these changes
Mar 21, 2025
dougch
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
As a followup to #2556 (comment), this changes the credential mapping from an LRU to a DashMap that preserves the association for the lifetime of the channel. This should avoid issues where the two get out of sync and end up trying to create a new stream only to get a replay detected error.
Testing:
I added a test showing that the association is preserved as long as one of the receivers is active. As soon as both are dropped, the association is removed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.