ci: Fixes parsing of MSRV #2555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Mar 18, 2025
camshaft
approved these changes
Mar 19, 2025
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/s2n-quic
that referenced
this pull request
Mar 25, 2025
* Fixes parsing of MSRV * Pins half and errorchecks MSRV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
N/A
Description of changes:
Fixes parsing of MSRV. Previously we were testing with the newest toolchain, rather than our stated MSRV. Also includes a pin of the package 'half' which bumped their MSRV.
Call-outs:
N/A
Testing:
CI needs to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.