Skip to content

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Mar 12, 2025

Release Summary:

Resolved issues:

resolves #2524.

Description of changes:

This PR will replace our humantime library with jiff.

One of our dependency humantime hasn't been updated for four years and is currently not maintained. Github action has cut us a ticket, asking us to consider alternatives. The recommended alternative for humantime is jiff, a newly developed daytime library.

I have incorporated jiff in s2n-quic-sim.

Call-outs:

Instead of Duration, jiff provides SignedDuration:

Unlike std::time::Duration, this duration is signed. The sign applies to the entire duration.
That is, either both the seconds and the fractional nanoseconds are negative or neither are.

We primarily use it in CliRange:

#[derive(Copy, Clone, Debug, PartialEq, Eq)]
pub struct CliRange<T> {
pub start: T,
pub end: T,
}

Testing:

This will be tested by the CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang requested a review from camshaft March 12, 2025 18:10
@boquan-fang boquan-fang marked this pull request as ready for review March 12, 2025 18:10
Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@boquan-fang boquan-fang merged commit ce5a6b7 into aws:main Mar 12, 2025
117 of 118 checks passed
@boquan-fang boquan-fang deleted the replace-humantime branch March 12, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2025-0014: humantime is unmaintained
2 participants