Skip to content

[release-0.23] Ubuntu/Rhel Certificate Renewal Implementation (Part 2 of the certificate renewal command feature) #9959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 29, 2025
Merged

[release-0.23] Ubuntu/Rhel Certificate Renewal Implementation (Part 2 of the certificate renewal command feature) #9959

merged 9 commits into from
Jul 29, 2025

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #9781

/assign panktishah26

@eks-distro-pr-bot eks-distro-pr-bot mentioned this pull request Jul 29, 2025
Merged
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 29, 2025
@panktishah26
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: panktishah26

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 8.16327% with 315 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-0.23@7050b52). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/certificates/renewer.go 0.00% 108 Missing ⚠️
pkg/certificates/renewerubuntu.go 0.00% 85 Missing ⚠️
pkg/certificates/ssh.go 0.00% 81 Missing ⚠️
cmd/eksctl-anywhere/cmd/renewcertificates.go 25.00% 21 Missing ⚠️
pkg/certificates/config.go 58.33% 10 Missing and 5 partials ⚠️
pkg/certificates/os.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##             release-0.23    #9959   +/-   ##
===============================================
  Coverage                ?   69.41%           
===============================================
  Files                   ?      679           
  Lines                   ?    50679           
  Branches                ?        0           
===============================================
  Hits                    ?    35180           
  Misses                  ?    13709           
  Partials                ?     1790

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@panktishah26 panktishah26 merged commit 2db885a into aws:release-0.23 Jul 29, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@panktishah26 panktishah26

Labels
approved lgtm needs-ok-to-test size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eks-distro-pr-bot @eks-distro-bot @panktishah26 @howard-junec