Skip to content

Remove vSphere feature flag #9827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Remove vSphere feature flag #9827

merged 1 commit into from
Jun 19, 2025

Conversation

rajeshvenkata
Copy link
Member

@rajeshvenkata rajeshvenkata commented Jun 18, 2025 •
edited
Loading

Issue #, if available:

Description of changes:
Remove vSphere feature flag

Testing (if applicable):
Tested cluster creation with failure domain and without failure domain.

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 18, 2025
@rajeshvenkata
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajeshvenkata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.87%. Comparing base (b602079) to head (e66ed53).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
controllers/cluster_controller.go 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           main    #9827       +/-   ##
=========================================
+ Coverage      0   69.87%   +69.87%     
=========================================
  Files         0      675      +675     
  Lines         0    50348    +50348     
=========================================
+ Hits          0    35182    +35182     
- Misses        0    13359    +13359     
- Partials      0     1807     +1807

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rajeshvenkata rajeshvenkata force-pushed the remove-vsphere-fd-featureflag branch from 9d63383 to e66ed53 Compare June 18, 2025 07:01
@rajeshvenkata
Copy link
Member Author

codecv failure is expected because original reconcileDelete method did not have any coverage. This can be handled in another issue or PR

@2ez4szliu
Copy link
Member

/lgtm

@rajeshvenkata rajeshvenkata merged commit aec5c18 into aws:main Jun 19, 2025
11 of 13 checks passed
@rajeshvenkata rajeshvenkata deleted the remove-vsphere-fd-featureflag branch June 19, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@2ez4szliu 2ez4szliu

Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajeshvenkata @eks-distro-bot @2ez4szliu