Added u16 endian loading/storing functions, SSL_CIPHER_find, and SSL_client_hello_get0_ciphers #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ello_get0_ciphers
…0_ciphers, finished testing for both
andrewhop
reviewed
Mar 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
+ Coverage 77.01% 77.21% +0.19%
==========================================
Files 426 426
Lines 71738 71485 -253
==========================================
- Hits 55252 55194 -58
+ Misses 16486 16291 -195 ☔ View full report in Codecov by Sentry. |
andrewhop
reviewed
Mar 13, 2024
andrewhop
previously approved these changes
Mar 18, 2024
justsmth
reviewed
Mar 20, 2024
andrewhop
reviewed
Mar 29, 2024
justsmth
approved these changes
Apr 4, 2024
andrewhop
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added u16 endian loading/storing functions, SSL_CIPHER_find, and SSL_client_hello_get0_ciphers and tested all of them.
Call-outs:
SSL_client_hello_get0_ciphers uses a new field added to ssl_st: ssl->client_hello_cipher_suites_arr.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.