Add options lambdaurl.WithDetectContentType and lambda.WithContextValue #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
+ Coverage 72.90% 72.93% +0.03%
==========================================
Files 26 26
Lines 1421 1456 +35
==========================================
+ Hits 1036 1062 +26
- Misses 314 322 +8
- Partials 71 72 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#508
Description of changes:
Adds an option to utilize the stblib http.DetectContentType on the first
Writeto a lambda url response writer. This is done by adding alambda.WithContextValueas a mechinisim to squirrel arbitrary context values inStartWithOptionswrappers likelambdaurl.StartBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.