Skip to content

fix: zero attempt should return error when RetryIf returns false #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix: zero attempt should return error when RetryIf returns false #86

merged 1 commit into from
Apr 21, 2023

Conversation

lizhiquan
Copy link
Contributor

fixes #66

JaSei
JaSei approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@JaSei JaSei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

@JaSei JaSei merged commit a9a7017 into avast:master Apr 21, 2023
@JaSei JaSei mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaSei JaSei JaSei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not calling RetryIfFunc when Attempt(0)
2 participants
@lizhiquan @JaSei