Skip to content

fix: zero attempt should return error when the error is either unrecoverable or context error #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: zero attempt should return error when the error is either unrecoverable or context error #84

merged 1 commit into from
Feb 8, 2023

Conversation

lizhiquan
Copy link
Contributor

fixes #83

@JaSei
Copy link
Collaborator

JaSei commented Feb 8, 2023

Thanks for your PR

@JaSei JaSei merged commit 9ae5a72 into avast:master Feb 8, 2023
lizhiquan pushed a commit to lizhiquan/retry-go that referenced this pull request Feb 12, 2023
new version with PR avast#84
0407c19
@yoheiueda yoheiueda mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaSei JaSei JaSei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

retry.Attempts(0) causes retry to not return error on context timeout
2 participants
@lizhiquan @JaSei