Skip to content

fix: reslice error log to remove nil values #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

fix: reslice error log to remove nil values #81

merged 2 commits into from
Jan 3, 2023

Conversation

JamieEdge
Copy link
Contributor

Fixes #80.

Based on #78 to update tests and avoid causing a failure due to a nil value being expected, as referenced below.

retry-go/retry_test.go

Line 167 in 54c42e0

expectedErr := Error{testErr, nil}

⚠️ This may be considered a breaking change because some consumers of the package may expect the length of the error to be the maximum number of attempts rather than the actual number.

@JaSei
Copy link
Collaborator

JaSei commented Jan 3, 2023

thank you for your PR

@JaSei JaSei merged commit e1515ac into avast:master Jan 3, 2023
JaSei pushed a commit that referenced this pull request Jan 3, 2023
bump version of fixes #79 #80 #81
c65eeae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaSei JaSei JaSei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Length of Error returned by Do does not reflect number of attempts
2 participants
@JamieEdge @JaSei