-
Notifications
You must be signed in to change notification settings - Fork 314
Add tokenForConnection method to OAuth #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+178
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df928de.
frederikprijck
requested changes
Mar 4, 2025
tanya732
previously approved these changes
Mar 28, 2025
frederikprijck
requested changes
Mar 28, 2025
frederikprijck
requested changes
Mar 28, 2025
frederikprijck
requested changes
Mar 28, 2025
frederikprijck
requested changes
Mar 28, 2025
frederikprijck
requested changes
Mar 28, 2025
update implementation to match current node auth0 methods
frederikprijck
previously requested changes
Mar 28, 2025
tanya732
previously approved these changes
Mar 28, 2025
Co-authored-by: Frederik Prijck <frederik.prijck@auth0.com>
arpit-jn
approved these changes
Mar 28, 2025
these changes have been incorporated
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tokenForConnection method to OAuth
Description
This PR adds a new
tokenForConnection
method to the OAuth class that allows exchanging a refresh token for a federated connection access token. This is particularly useful when you need to access a social provider's API using the user's refresh token.This PR also removes enforcing namespace ownership requirements for token types in custom token exchange (this is not required to be done on SDK side)
References
Changes
TokenForConnectionOptions
interface with requiredrefreshToken
andconnection
parameters, and optionalloginHint
tokenForConnection
method with proper parameter validation and error handlingManual Testing Steps
Test Results
PASSING