Skip to content

Conversation

teor2345
Copy link
Member

There are some confusing references to "testnet" in code that is also used for mainnet, like:

  • CI: Generate testnet chain specifications / domain genesis storages
  • Code: mainnet_config(get_testnet_genesis_by_spec_id(SpecId::Mainnet))

We also still talk about testnet wallets in the farmer instructions.

Code contributor checklist:

@teor2345 teor2345 self-assigned this Aug 14, 2025
@teor2345 teor2345 requested a review from vedhavyas as a code owner August 14, 2025 22:38
@teor2345 teor2345 added the documentation Improvements or additions to documentation label Aug 14, 2025
@teor2345 teor2345 requested a review from nazar-pc as a code owner August 14, 2025 22:38
Copy link

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

Base automatically changed from chronos_testnet to main August 15, 2025 09:04
@teor2345 teor2345 enabled auto-merge August 18, 2025 01:40
@teor2345 teor2345 added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit dc698b1 Aug 18, 2025
13 checks passed
@teor2345 teor2345 deleted the confusing-testnet-names branch August 18, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants