-
Notifications
You must be signed in to change notification settings - Fork 254
Chronos Testnet chainspec #3674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0517715
to
bd7b91c
Compare
Could technically be anything, IIRC it is not limited to 16 bytes either. Could pick the most recent Bitcoin block hash like mainnet did. Also entropy is technically optional. |
bd7b91c
to
a164226
Compare
Alright, @jfrank-summit can you do a final pass before I generate a raw spec please? I have given Council members some balance since Sudo is derived from their Multisig and Sudo 1000 Ai3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
This is good for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There are some confusing names in the code that are used for testnet and mainnet, like:
- CI: Generate testnet chain specifications / domain genesis storages
- Code:
mainnet_config(get_testnet_genesis_by_spec_id(SpecId::Mainnet))
But they aren't a blocker for this PR, I'll fix them separately.
Adds chronos testnet chainspec.
@jfrank-summit @nazar-pc I have left some TODOs in there would appreciate some info on those.@nazar-pc as for thepot_external_entropy
, can I pick a random 16byte entropy or are there any specific steps you would like to do to derive oneOnce all TODOs are finalized, will generate a raw chainspec and remove any remnants of taurusCode contributor checklist: