make subspace gateway panic on restart need jsonrpsee error #3673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
teor2345
reviewed
Aug 11, 2025
teor2345
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #3671 by making the thread in which the subspace-gateway's
PieceValidatorlives panic when thejsonrpseecall returns thejsonrpsee::core::client::Error::RestartNeedederror.Why this solution?
I implemented the check in
SegmentCommitmentPieceValidatorsince it would have required to update the interface ofPieceValidatorto implement it in an upper layer and this component is used uniquely by the gateway where this logic applies.Tests
I've tested on taurus staging files gateway being able to replicate the error and correctly checked that the error is managed correctly.
Close #3671
Code contributor checklist: