Fix process exit checks and logs #3669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
vedhavyas
reviewed
Aug 5, 2025
crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
Outdated
Show resolved
Hide resolved
nazar-pc
reviewed
Aug 5, 2025
crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
Outdated
Show resolved
Hide resolved
crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
Outdated
Show resolved
Hide resolved
crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
Outdated
Show resolved
Hide resolved
crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
Outdated
Show resolved
Hide resolved
crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
Outdated
Show resolved
Hide resolved
d9e9c09 to
15c5a36
Compare
|
This should be ready for another review, I removed the controversial changes and just kept the bootstrap node prometheus task and type checks. |
nazar-pc
approved these changes
Aug 13, 2025
nazar-pc
added a commit
to nazar-pc/abundance
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR treats the bootstrap node prometheus task as non-essential, and explicitly ignores some exit errors.
Fixes
The boostrap node treats its prometheus task as non-essential: it doesn't exit if that task exits. This matches farmer behaviour. I added comments so we don't accidentally change this in future.
Type Checks
When we ignore a task cancellation, I added explicit types, so we don't accidentally ignore any other errors.
Refactors
I simplified the prometheus select code in the farmer and bootstrap node, so we don't have multiple
select!statements. This requires the pattern matching feature oftokio::select!:https://tokio.rs/tokio/tutorial/select#pattern-matching
Code contributor checklist: