Fix missing share price for de-registered operators #3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛡️ Immunefi PR ReviewsThanks for submitting this PR for review! We’ve assigned 6 code reviewer(s) to take a look. They’ll provide feedback here as soon as possible. This review is based on the current state of your pull request. If you make changes after the review starts, they won’t be reflected here. To ensure the review includes your latest updates, you’ll need to open a new pull request. |
4f85096 to
9248e56
Compare
1 task
…ards but not in next operator set
9248e56 to
76c1547
Compare
teor2345
approved these changes
Aug 3, 2025
| @@ -60,11 +64,22 @@ pub(crate) fn do_finalize_domain_current_epoch<T: Config>( | |||
| }) | |||
| } | |||
|
|
|||
| /// Result holding after `operator_take_reward_tax_and_stake` | |||
| pub(crate) struct OperatorTakeRewardTaxResult { | |||
There was a problem hiding this comment.
Usually in Rust, structs named Result have an Ok and Error case. A better name here would be:
Suggested change
| pub(crate) struct OperatorTakeRewardTaxResult { | |
| pub(crate) struct OperatorTakeRewardTaxOutcome { |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How de-registration of operator works?
Operator sends a de-registration extrinsics and status is moved to DeRegistered with ability to unlock funds after specified withdrawal period. After this no more deposits, withdrawals, and unlocking of already initiated withdrawals is accepted. Once the withdrawal period is complete, each nominator can submit
unlock_nominatorto get their funds back. Operator is also removed from the next_operator set.How Operator rewards are distributed?
Once a domain ER is confirmed, we note the rewards for operators who submitted that ER and distribute any rewards from that ER to these operators. If the operator is slashed or queued to be slashed, then that operator will not receive these rewards and instead deposited to treasury else they will be give these rewards.
How Epoch is transitioned?
When epoch is complete, protocol transitions given domain to next epoch. Before doing that, it accounts for all the deposits, withdrawals submitted to this operator during the epoch and finalizes them.
If the operator has set any nomination tax percentage then portion of rewards given to operator during the epoch are given to the operator and rest is distributed pro-rate to each nominator of the operator. Now when operator has non-zero tax-amount, protocol automatically deposit that tax-amount to operator as a new deposit.
During the epoch transition, if any operators in the next_operator set has any non-zero deposits or withdrawals, protocol calculates the share price for convert deposits into shares and withdrawals into Ai3.
What happened on taurus?
Seems like operator-8 have de-registered at epoch
23285but they got a reward at epoch23299.So during the epoch transition, operator 8 had a non-zero tax amount and protocol deposited that tax-amount to operator as a new deposit.
Unfortunately, share price for operator 8 is not calculated since they are not in next_operator set as they have de-registered previously even though they had a new deposit done by the protocol.
Later coming to epoch
23347, operator 8 received another reward and had a non-zero tax amount. When depositing this new tax-amount reward for operator 8, protocol tried to convert previous deposit from23299but failed to convert to shares since there was no share price.Due to this, epoch was never transitioned and all the bundles being submitted are failing.
Fix
This PR handles two things
Code contributor checklist: