Skip to content

Avoid Fn generics in bundle versions #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2025
Merged

Avoid Fn generics in bundle versions #3646

merged 4 commits into from
Jul 23, 2025

Conversation

teor2345
Copy link
Member

This PR removes Fn generics in bundle versions, instead just calling those functions in the caller.

It also expands some of the bundle version comments.

Code contributor checklist:

@teor2345 teor2345 self-assigned this Jul 22, 2025
@teor2345 teor2345 added refactor execution Subspace execution labels Jul 22, 2025
@immunefi-magnus Immunefi Magnus

This comment was marked as off-topic.

Sign in to view
@teor2345 teor2345 mentioned this pull request Jul 22, 2025
Merged
1 task
@teor2345 teor2345 force-pushed the versioned_bundle_no_fns branch from 89418ce to ebcac25 Compare July 23, 2025 00:02
@teor2345 teor2345 requested a review from nazar-pc as a code owner July 23, 2025 00:02
@teor2345 teor2345 mentioned this pull request Jul 23, 2025
Closed
1 task
Base automatically changed from versioned_bundle to main July 23, 2025 00:53
@teor2345 teor2345 mentioned this pull request Jul 23, 2025
Open
@teor2345 teor2345 enabled auto-merge July 23, 2025 02:59
vedhavyas
vedhavyas reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@teor2345 teor2345 disabled auto-merge July 23, 2025 03:31
@teor2345 teor2345 enabled auto-merge July 23, 2025 03:31
@teor2345 teor2345 added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2025
@vedhavyas vedhavyas added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit ebda4f6 Jul 23, 2025
22 of 23 checks passed
@vedhavyas vedhavyas deleted the versioned_bundle_no_fns branch July 23, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhavyas vedhavyas vedhavyas approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc nazar-pc is a code owner

+1 more reviewer

@NingLin-P NingLin-P NingLin-P approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@teor2345 teor2345

Labels
execution Subspace execution refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @vedhavyas @NingLin-P