Skip to content

Conversation

vedhavyas
Copy link
Contributor

Just cleaning up compatibility code we had for taurus.

Code contributor checklist:

Copy link

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

@vedhavyas vedhavyas added the breaking-execution This PR introduces breaking changes to the execution label Jul 16, 2025
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good

@@ -1130,7 +1105,6 @@ sp_api::decl_runtime_apis! {
/// - Pending deposits (not yet converted to shares)
/// - Pending withdrawals (with unlock timing)
///
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
///

NingLin-P
NingLin-P previously approved these changes Jul 17, 2025
Copy link
Contributor

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@teor2345

This comment was marked as resolved.

teor2345
teor2345 previously approved these changes Jul 22, 2025
Base automatically changed from versioned_bundle to main July 23, 2025 00:53
@vedhavyas vedhavyas dismissed stale reviews from teor2345 and NingLin-P July 23, 2025 00:53

The base branch was changed.

@vedhavyas vedhavyas added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 69ce87e Jul 23, 2025
12 checks passed
@vedhavyas vedhavyas deleted the cleanup branch July 23, 2025 03:48
@vanhauser-thc vanhauser-thc moved this from Backlog to Scheduled in Security Audit (PRs) Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-execution This PR introduces breaking changes to the execution
Projects
Status: Scheduled
Development

Successfully merging this pull request may close these issues.

3 participants