-
Notifications
You must be signed in to change notification settings - Fork 212
Closed
Labels
Milestone
Description
Classification:
Crash / locks up
Reproducibility:
Always
Summary
We don't seem to do any validation on the user's input for regex matching. The app then doesn't gracefully handle a regex string which Python re
doesn't parse.
Steps to Reproduce (if applicable)
- Enter a malformed regex for a phrase, like the single character,
*
. - Attempt to save this change.
- Try to trigger the phrase.
Expected Results
Good: The app shouldn't crash.
Better: It should trap and output re
errors somewhere.
Best: the app should validate the user input by attempting an re
compile when a user provides a regex. If it fails, then the regex won't be saved.
Actual Results
The app progressively locks up, and the UI needs to be killed. The server then crashes.
Version
AutoKey version: 0.95.4
Used GUI (Gtk, Qt, or both): Gtk
Distro: Fedora
Notes
I think this would be a good first PR for me to work on.