[common] Fix deprecation warnings #3463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shchur
commented
Aug 17, 2023
| @@ -27,7 +27,7 @@ def _deprecation_warning( | |||
| warnings.warn( | |||
| f"Deprecation Warning: {msg}. This will raise an error in the future!", | |||
| category=DeprecationWarning, | |||
| stacklevel=2, | |||
| stacklevel=3, | |||
| ) | |||
There was a problem hiding this comment.
@yinweisu an even "safer" option (more visible, but also more intrusive) would be to use category=UserWarning, which will ensure that the warnings are shown under the default warning filter configuration. Is that an overkill?
|
Job PR-3463-ad2f509 is done. |
yinweisu
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation warnings generated by the
Deprecateddecorator are currently silenced. This happens because Python silences allDeprecationWarnings by default, except those that occur inside theif __name__ = "__main__:"idiom (PEP565).Minimal working example
With the current value
stacklevel=2the warnings are attributed to the decorator insidecommon/src/autogluon/common/utils/deprecated_utils.py, so they are silenced.Description of changes:
stacklevel=3to attribute the warnings to the the main script. This ensures that the warnings are correctly displayed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.