Skip to content

Conversation

celestinoxp
Copy link
Contributor

@celestinoxp celestinoxp commented May 15, 2025

Fixes #5114

Description of changes:
This PR fixes a bug in the TabularPredictor constructor where positive_class was incorrectly accessed from kwargs, causing a KeyError when passed as a named argument. The line:

learner_kwargs["positive_class"] = kwargs["positive_class"]

has been corrected to:

learner_kwargs["positive_class"] = positive_class

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Job PR-5129-946e283 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-5129/946e283/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the bug fix!!

@Innixma Innixma added this to the 1.4 Release milestone May 19, 2025
@Innixma Innixma added module: tabular bug Something isn't working labels May 19, 2025
@Innixma Innixma merged commit cb3846c into autogluon:master May 19, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: tabular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't set positive_class for tabular predictor
2 participants