Skip to content

[Tabular] Raise on NaN val if raise_on_model_failure=True #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[Tabular] Raise on NaN val if raise_on_model_failure=True #5055

merged 1 commit into from
Apr 16, 2025

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Apr 16, 2025

Issue #, if available:

Description of changes:

  • Raise on NaN val if raise_on_model_failure=True
  • Improve return type hint for load_json which can return a list or a dict.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 1.3 Release milestone Apr 16, 2025
@Innixma Innixma requested review from tonyhoo and prateekdesai04 and removed request for tonyhoo April 16, 2025 19:42
@Innixma Innixma merged commit 5141bf8 into autogluon:master Apr 16, 2025
25 checks passed
@Innixma Innixma deleted the improve_error_raise_on_model_failure branch April 16, 2025 20:56
@github-actions GitHub Actions
Copy link

Job PR-5055-f509854 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-5055/f509854/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekdesai04 prateekdesai04 prateekdesai04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Innixma @prateekdesai04