Sklearn update to 1.6+ #5029
Merged
Sklearn update to 1.6+ #5029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-5029-832278a is done. |
suzhoum
approved these changes
Apr 11, 2025
| @@ -797,8 +798,8 @@ def _calculate_total_resources( | |||
| ), f"Specified num_cpus per {self.__class__.__name__} is more than the total: {system_num_cpus}" | |||
| if user_specified_lower_level_num_gpus is not None: | |||
| assert ( | |||
| user_specified_lower_level_num_gpus <= system_num_cpus | |||
| ), f"Specified num_gpus per {self.__class__.__name__} is more than the total: {system_num_cpus}" | |||
| user_specified_lower_level_num_gpus <= system_num_gpus | |||
Innixma
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Code looks good to me!
However, the website shows many warnings that need to be addressed:
Mainline for comparison: https://auto.gluon.ai/dev/tutorials/tabular/tabular-essentials.html
|
Job PR-5029-502c530 is done. |
Innixma
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5028
Description of changes:
Update Sklearn to 1.6+. Test failures related with sklearn update
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.