Skip to content

Conversation

tonyhoo
Copy link
Collaborator

@tonyhoo tonyhoo commented Mar 4, 2025

Issue #, if available:
N/A

Description of changes:

  • Updated LightGBM dependency to require version 4.6.x (previously 4.0.x-4.5.x)
  • Fixed code formatting issues in setup.py

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@emiliocanor
Copy link

if merged, do we know when this change will be released? I see 1.2.1 and 1.3 releases are planned right now but neither has a due date.

@tonyhoo
Copy link
Collaborator Author

tonyhoo commented Mar 4, 2025

We’re looking at a possible release in 1.3, considering all the changes merged so far. While we don’t have a specific release date yet, early Q2 is our tentative target

Copy link

github-actions bot commented Mar 4, 2025

Job PR-4960-d66ece0 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4960/d66ece0/index.html

tabular/setup.py Outdated
@@ -34,7 +34,7 @@

extras_require = {
"lightgbm": [
"lightgbm>=4.0,<4.6", # <{N+1} upper cap, where N is the latest released minor version
"lightgbm>=4.6,<4.7", # <{N+1} upper cap, where N is the latest released minor version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so strict? Why not >=4.0,<4.7?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum version of LightGBM to mitigate the security vulnerability is 4.6.0, as outlined in this report.

Copy link

github-actions bot commented Mar 5, 2025

Job PR-4960-a321461 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4960/a321461/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonyhoo
Copy link
Collaborator Author

tonyhoo commented Mar 6, 2025

/platform_tests a321461
Platform Tests Output

@tonyhoo tonyhoo merged commit 09c1134 into autogluon:master Mar 6, 2025
27 checks passed
@tonyhoo tonyhoo deleted the lightgbm_upgrade branch March 13, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants