-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix source installation issue on colab #4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 626abf7.
full_install.sh
Outdated
# Get the directory of the script | ||
script_dir=$(dirname "$0") | ||
|
||
# Change the current directory to the script's directory | ||
cd "$script_dir" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead we only do this logic if not in a colab environment, instead of removing it?
Alternative, don't remove it, but if colab, force --non-editable
flag setting. This should also fix the issue, since there is no need to have editable install in colab.
…luon#4933)"" This reverts commit 0e03412.
Job PR-4964-0e03412 is done. |
Job PR-4964-ca6900a is done. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Job PR-4964-f71b0d3 is done. |
/platform_tests 448150b |
Job PR-4964-448150b is done. |
full_install.sh
Outdated
echo "Colab detected - forcing non-editable install" | ||
else | ||
EDITABLE="true" | ||
cd "$script_dir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we try moving the cd "$script_dir"
outside of the if/else, so it always happens? This should fix the below:
Ideally this should work in colab:
!git clone -b revert_change https://github.com/tonyhoo/autogluon.git
!./autogluon/full_install.sh
But it doesn't currently:
error: Distribution not found at: file:///content/common
/platform_tests 5ea605f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on colab!
Job PR-4964-5ea605f is done. |
This reverts commit 626abf7.
Issue #, if available:
N/A
Description of changes:
Reverting changes to
full_install.sh
that addedcd "$script_dir"
. This change caused problems with editable installations in Colab environments, where the src-layout structure combined with changing directories resulted in Python being unable to find the correct modules.The revert ensures that users installing AutoGluon from source in Colab can properly import modules like
TabularPredictor
without additional workarounds. This issue primarily affects researchers and developers who install from source in notebook environments.Testing verified at: Colab
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.