Skip to content

[tabular] Add raise_on_model_failure flag #4937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

[tabular] Add raise_on_model_failure flag #4937

merged 3 commits into from
Feb 26, 2025

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Feb 26, 2025

Issue #, if available:

Description of changes:

  • Add raise_on_model_failure flag (default False)
  • When True, will immediately raise the original exception if a model raises an exception during fit.
  • Setting to True is very helpful when using a debugger to try to figure out why a model is failing, as otherwise exceptions are handled by AutoGluon which isn't desired while debugging.
  • Docstring / type hint improvements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 1.3 Release milestone Feb 26, 2025
@github-actions GitHub Actions
Copy link

Job PR-4937-6099c71 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4937/6099c71/index.html

canerturkmen
canerturkmen reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I would only encourage adding tests. If somebody else decides to catch the model errors (i.e., the learner starts catching stuff), the behavior will break.

tabular/src/autogluon/tabular/predictor/predictor.py Outdated
This is useful when using a debugger during development to identify the cause of model failures.
This should only be used for debugging.
If False, will try to skip to the next model if an exception occurred during model training.
This is the default logic and is a core principal of AutoGluon's design.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo -> principle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@Innixma
Copy link
Contributor Author

Innixma commented Feb 26, 2025

added unit test, good suggestion @canerturkmen !

@Innixma Innixma merged commit ff2178d into autogluon:master Feb 26, 2025
4 checks passed
@github-actions GitHub Actions
Copy link

Job PR-4937-96dcdd7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4937/96dcdd7/index.html

@Innixma Innixma deleted the raise-on-model-failure branch April 16, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canerturkmen canerturkmen canerturkmen approved these changes

@shchur shchur Awaiting requested review from shchur

@prateekdesai04 prateekdesai04 Awaiting requested review from prateekdesai04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Innixma @canerturkmen