Fix setup_outputdir #4903
Merged
Fix setup_outputdir #4903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shchur
reviewed
Feb 18, 2025
| @@ -22,7 +24,7 @@ | |||
| LITE_MODE: bool = __lite__ is not None and __lite__ | |||
|
|
|||
|
|
|||
| def setup_outputdir(path, warn_if_exist=True, create_dir=True, path_suffix=None): | |||
| def setup_outputdir(path: str | None, warn_if_exist: bool = True, create_dir: bool = True, path_suffix: str | None = None) -> str: | |||
There was a problem hiding this comment.
As a general comment, do we ever call setup_outpudir(path=None) during predictor.fit()? Or is this just a fallback option that is used when the model is used as a standalone object?
There was a problem hiding this comment.
Yes we do, for example, if predictor = TabularPredictor(label=label), this calls setup_outputdir(path=None) to create the predictor's directory.
There was a problem hiding this comment.
Example prior to this PR showing the unnecessary warning:
No path specified. Models will be saved in: "AutogluonModels/ag-20250218_215911"
Warning: path already exists! This predictor may overwrite an existing predictor! path="AutogluonModels/ag-20250218_215911"
|
Job PR-4903-3e7be79 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix setup_outputdir
path=None. Previously it could result in appending a str toag-{timestamp}without making a new directory. For example, initializing CatBoostModel withpath=Nonewould createAutogluonModels/ag-{...}CatBoost, instead ofAutogluonModels/ag-{...}/CatBoostpath=Noneis the input.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.