[tabular] Add FutureWarning for delete_models dry_run #4905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-4905-d41ea3b is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add FutureWarning for TabularPredictor.delete_models when dry_run is not specified.
The idea is that when users call
delete_models, it is likely they would prefer for the deletion to occur rather than it being a dry run. It may be hard for users to consistently remember to setdry_run=False, so this PR makes it that starting in v1.4.0, dry_run will default to False instead of True.@shchur I notice that there is no
delete_modelsequivalent in TimeSeriesPredictor. Might be something interesting to have in future.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.